| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <d21ad74592c295d59f5806f30a053745b5765397.1292894256.git.tfransosi@gmail.com> Date: Mon, 20 Dec 2010 23:18:06 -0200 From: Thiago Farina <tfransosi@...il.com> To: linux-kernel@...r.kernel.org Cc: Thiago Farina <tfransosi@...il.com>, Guennadi Liakhovetski <g.liakhovetski@....de>, Mauro Carvalho Chehab <mchehab@...radead.org>, linux-media@...r.kernel.org Subject: [PATCH] drivers/media/video/v4l2-compat-ioctl32.c: Check the return value of copy_to_user This fix the following warning: drivers/media/video/v4l2-compat-ioctl32.c: In function ‘get_microcode32’: drivers/media/video/v4l2-compat-ioctl32.c:209: warning: ignoring return value of ‘copy_to_user’, declared with attribute warn_unused_result Signed-off-by: Thiago Farina <tfransosi@...il.com> --- drivers/media/video/v4l2-compat-ioctl32.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/v4l2-compat-ioctl32.c b/drivers/media/video/v4l2-compat-ioctl32.c index e30e8df..55825ec 100644 --- a/drivers/media/video/v4l2-compat-ioctl32.c +++ b/drivers/media/video/v4l2-compat-ioctl32.c @@ -206,7 +206,9 @@ static struct video_code __user *get_microcode32(struct video_code32 *kp) * user address is invalid, the native ioctl will do * the error handling for us */ - (void) copy_to_user(up->loadwhat, kp->loadwhat, sizeof(up->loadwhat)); + if (copy_to_user(up->loadwhat, kp->loadwhat, sizeof(up->loadwhat))) + return NULL; + (void) put_user(kp->datasize, &up->datasize); (void) put_user(compat_ptr(kp->data), &up->data); return up; -- 1.7.3.2.343.g7d43d -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists