linux-kernel - Re: [V2 PATCH] kthread_work: Make lockdep happy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1292947628.14806.3.camel@morgan.silverblock.net>
Date:	Tue, 21 Dec 2010 11:07:08 -0500
From:	Andy Walls <awalls@...metrocast.net>
To:	Tejun Heo <tj@...nel.org>
Cc:	Yong Zhang <yong.zhang0@...il.com>, linux-kernel@...r.kernel.org,
	nicolas.mailhot@...oste.net, Jarod Wilson <jarod@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [V2 PATCH] kthread_work: Make lockdep happy

On Tue, 2010-12-21 at 13:59 +0100, Tejun Heo wrote:
> Hello,
> 
> On Tue, Dec 21, 2010 at 12:40:50PM +0800, Yong Zhang wrote:
> > From: Yong Zhang <yong.zhang0@...il.com>
> > Subject: [V2 PATCH] kthread_work: Make lockdep happy
> > 
> > spinlock in kthread_worker and wait_queue_head in kthread_work
> > both should be lockdep sensible.
> > So change the interface to make it suiltable for CONFIG_LOCKDEP.
> > 
> > Reported-by: Nicolas <nicolas.mailhot@...oste.net>
> > Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
> > Cc: Tejun Heo <tj@...nel.org>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Cc: Andy Walls <awalls@...metrocast.net>
> > ---
> > Changes from V1:
> >  *According to Tejun, kthread_worker could be defined on stack,
> >   So introduce DEFINE_KTHREAD_WORKER_ONSTACK.
> >  *Change wrong setting to kthread_work->task. Thanks Adny for
> >   pointing it.
> >  *including some minor issue.
> > 
> > BTW, only passed build.
> 
> If somebody can confirm this makes lockdep behave correctly, I'll
> route it through the wq tree.

I will attempt to test later tonight with at least one ivtv (PVR-350)
card installed.  If I have time, I'll test with two cards (PVR-350 and
PVR-150) installed in the machine, since that will create two different
kthread_workers, each with their own lock.

How can I dump information on lockdep spinlock tracking to verify that
the two distinct locks are tracked separately by lockdep?

Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/