linux-kernel - [PATCH 10/10] xen/mmu: Warn against races.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1292967460-15709-11-git-send-email-konrad.wilk@oracle.com>
Date:	Tue, 21 Dec 2010 16:37:40 -0500
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	linux-kernel@...r.kernel.org, jeremy@...p.org, hpa@...or.com
Cc:	Jan Beulich <JBeulich@...ell.com>, xen-devel@...ts.xensource.com,
	Konrad Rzeszutek Wilk <konrad@...nel.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: [PATCH 10/10] xen/mmu: Warn against races.

The initial bootup code uses set_phys_to_machine quite a lot, and after
bootup it would be the balloon driver. The balloon driver does have
mutex lock so this should not be necessary - but just in case, add
a warning if we do hit this scenario.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
---
 arch/x86/xen/mmu.c |    8 +++++---
 1 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
index b2b8733..86d3bd3 100644
--- a/arch/x86/xen/mmu.c
+++ b/arch/x86/xen/mmu.c
@@ -549,13 +549,15 @@ bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn)
 	idx = p2m_index(pfn);
 
 	if (mfn == INVALID_P2M_ENTRY) {
-		/* If it is INVALID, swap over.. */
+		/* Ballon lock should inhibit racing, but just in case.*/
 		if (p2m_top[topidx] == p2m_mid_identity) {
-			p2m_top[topidx] = p2m_mid_missing;
+			WARN_ON(cmpxchg(&p2m_top[topidx], p2m_mid_identity,
+				p2m_mid_missing) != p2m_mid_identity);
 			return 1;
 		}
 		if (p2m_top[topidx][mididx] == p2m_identity) {
-			p2m_top[topidx][mididx] = p2m_missing;
+			WARN_ON(cmpxchg(&p2m_top[topidx][mididx], p2m_identity,
+				p2m_missing) != p2m_identity);
 			return 1;
 		}
 	}
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/