linux-kernel - Re: [PATCH] kthread_worker: Initialize dynamically allocated spinlock properly for lockdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikVwGqhCxuCjW1AceBaZp-iCY=1cxge5xqyNSBd@mail.gmail.com>
Date:	Tue, 21 Dec 2010 09:54:18 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	Andy Walls <awalls@...metrocast.net>, linux-kernel@...r.kernel.org,
	nicolas.mailhot@...oste.net, Jarod Wilson <jarod@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH] kthread_worker: Initialize dynamically allocated spinlock
 properly for lockdep

On Tue, Dec 21, 2010 at 12:21 AM, Tejun Heo <tj@...nel.org> wrote:
> Hello,
>
> On 12/20/2010 10:28 AM, Yong Zhang wrote:
>> Subject: [PATCH] kthread_work: Make lockdep happy
>>
>> spinlock in kthread_worker and wait_queue_head in kthread_work
>> both should be lockdep annotated.
>> So change the interface to make it suiltable for CONFIG_LOCKDEP.
>>
>> Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
>> ---
>> I'm not sure if it's possible to define a worker on stack?
>> So I left DEFINE_KTHREAD_WORKER() untouched.
>
> Yes, it can, I think.

Thanks for your confirmation, I will update the patch in V2.

>BTW, where are you using kthread_worker?

I don't have anything using kthread_worker, but go through
the kernel and find ivtv is the only one.
This is why I sent the untested patch :)

> I'm
> planning to update its flush semantics similar to that of proper
> workqueue so that it's less confusing and switching between the two is
> easy, so its usage may change slightly soon, although conversion
> shouldn't be difficult.

No problem. Now I just make the patch based on the current
kthread_work*.

Thanks,
Yong

-- 
Only stand for myself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/