linux-kernel - Re: [PATCH] vgaarb: use bridges to control VGA routing where possible. (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101220200258.305889ec@jbarnes-desktop>
Date:	Mon, 20 Dec 2010 20:02:58 -0800
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Dave Airlie <airlied@...il.com>
Cc:	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Dave Airlie <airlied@...hat.com>
Subject: Re: [PATCH] vgaarb: use bridges to control VGA routing where
 possible. (v2)

On Mon, 20 Dec 2010 10:10:09 +1000
Dave Airlie <airlied@...il.com> wrote:

> - * @change_bridge: traverse ancestors and change bridges
> + * @change_bridge_flags: traverse ancestors and change bridges
> + * CHANGE_BRIDGE_ONLY / CHANGE_BRIDGE
>   */
>  int pci_set_vga_state(struct pci_dev *dev, bool decode,
> -		      unsigned int command_bits, bool change_bridge)
> +		      unsigned int command_bits, u32 flags)
>  {

Other than this nitpick, it looks sound to me; we'll need to actually
disable VGA decode in the shared bridge hierarchy case rather than just
using simple bridge routing.

Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/