lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Dec 2010 21:07:51 -0800 (PST) From: Hugh Dickins <hughd@...gle.com> To: Minchan Kim <minchan.kim@...il.com> cc: Christoph Hellwig <hch@...radead.org>, Andrew Morton <akpm@...ux-foundation.org>, linux-mm <linux-mm@...ck.org>, LKML <linux-kernel@...r.kernel.org> Subject: Re: [RFC 0/5] Change page reference hanlding semantic of page cache On Tue, 21 Dec 2010, Minchan Kim wrote: > On Mon, Dec 20, 2010 at 7:33 PM, Christoph Hellwig <hch@...radead.org> wrote: > > You'll need to merge all patches into one, otherwise you create really > > nasty memory leaks when bisecting between them. > > > > Okay. I will resend. > > Thanks for the notice, Christoph. Good point from hch, but I feel even more strongly: if you're going to do this now, please rename remove_from_page_cache (delete_from_page_cache was what I chose back when I misdid it) - you're changing an EXPORTed function in a subtle (well, subtlish) confusing way, which could easily waste people's time down the line, whether in not-yet-in-tree filesystems or backports of fixes. I'd much rather you break someone's build, forcing them to look at what changed, than crash or leak at runtime. If you do rename, you can keep your patch structure, introducing the new function as a wrapper to the old at the beginning, then removing the old function at the end. (As you know, I do agree that it's right to decrement the reference count at the point of removing from page cache.) Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists