| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1292916543.19556.46.camel@thor.local> Date: Tue, 21 Dec 2010 08:29:03 +0100 From: Michel Dänzer <michel@...nzer.net> To: Dave Airlie <airlied@...il.com> Cc: linux-fbdev@...r.kernel.org, Dave Airlie <airlied@...hat.com>, linux-kernel@...r.kernel.org, dri-devel@...ts.sf.net Subject: Re: [PATCH 1/3] fb: fix overlapping test off-by-one. On Die, 2010-12-21 at 11:41 +1000, Dave Airlie wrote: > From: Dave Airlie <airlied@...hat.com> > > On my system with a radeon x2, the first GPU was not overlapping vesa > but the test decided it was. > > Signed-off-by: Dave Airlie <airlied@...hat.com> > --- > drivers/video/fbmem.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c > index 0e6aa3d..4ac1201 100644 > --- a/drivers/video/fbmem.c > +++ b/drivers/video/fbmem.c > @@ -1458,7 +1458,7 @@ static bool apertures_overlap(struct aperture *gen, struct aperture *hw) > if (gen->base == hw->base) > return true; > /* is the generic aperture base inside the hw base->hw base+size */ > - if (gen->base > hw->base && gen->base <= hw->base + hw->size) > + if (gen->base > hw->base && gen->base < hw->base + hw->size) Good catch. Reviewed-by: Michel Dänzer <michel@...nzer.net> -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists