linux-kernel - Re: [V3 PATCH] kthread_work: Make lockdep happy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101222093341.GA4684@htj.dyndns.org>
Date:	Wed, 22 Dec 2010 10:33:41 +0100
From:	Tejun Heo <tj@...nel.org>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	Andy Walls <awalls@...metrocast.net>, linux-kernel@...r.kernel.org,
	nicolas.mailhot@...oste.net, Jarod Wilson <jarod@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Hans Verkuil <hverkuil@...all.nl>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [V3 PATCH] kthread_work: Make lockdep happy

On Wed, Dec 22, 2010 at 11:23:05AM +0800, Yong Zhang wrote:
> From: Yong Zhang <yong.zhang0@...il.com>
> Subject: [V3 PATCH] kthread_work: Make lockdep happy
> 
> spinlock in kthread_worker and wait_queue_head in kthread_work
> both should be lockdep sensible.
> So change the interface to make it suiltable for CONFIG_LOCKDEP.
> 
> Reported-by: Nicolas <nicolas.mailhot@...oste.net>
> Signed-off-by: Yong Zhang <yong.zhang0@...il.com>
> Signed-off-by: Andy Walls <awalls@...metrocast.net>
> Tested-by: Andy Walls <awalls@...metrocast.net>
> Cc: Tejun Heo <tj@...nel.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>

Applied with the following comment update (because the term "special
work" was a bit too confusing given the context) to wq#for-linus.
Will push out to Linus in several days.

+/*
+ * kthread_worker.lock and kthread_work.done need their own lockdep class
+ * keys if they are defined on stack with lockdep enabled.  Use the
+ * following macros when defining them on stack.
+ */

Thank you.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/