linux-kernel - Re: [tip:perf/core] perf probe: Don't always consider EOF as an error when listing source code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101222144338.GA17134@ghostprotocols.net>
Date:	Wed, 22 Dec 2010 12:43:38 -0200
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Franck Bui-Huu <vagabon.xyz@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	masami.hiramatsu.pt@...achi.com, tglx@...utronix.de
Subject: Re: [tip:perf/core] perf probe: Don't always consider EOF as an
	error when listing source code

Em Wed, Dec 22, 2010 at 02:14:43PM +0100, Franck Bui-Huu escreveu:
> tip-bot for Franck Bui-Huu <fbuihuu@...il.com> writes:
> >  error:
> > -	if (feof(fp))
> > +	if (ferror(fp)) {
> >  		pr_warning("Source file is shorter than expected.\n");
> > -	else
> > -		pr_warning("File read error: %s\n", strerror(errno));
> > +		return -1;
> 
> Argh, something wrong here.
> 
> The warning left here, is the wrong one, I should have left the other
> one.
> 
> Sorry for the mistake.
> 
> Should I send a patch to fix that ?

Please.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/