linux-kernel - Re: [PATCH] power: power_supply_core: fix use after free and memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101222000545.GC24834@oksana.dev.rtsoft.ru>
Date:	Wed, 22 Dec 2010 03:05:45 +0300
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Vasiliy Kulikov <segoon@...nwall.com>
Cc:	kernel-janitors@...r.kernel.org,
	David Woodhouse <dwmw2@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: power_supply_core: fix use after free and
 memory leak

On Fri, Nov 19, 2010 at 09:41:58PM +0300, Vasiliy Kulikov wrote:
> device_unregister() might free its argument.  This leads to freed
> memory use in kfree().  Also use put_device() instead of kfree()
> as dev may be already used in another layer after call to device_add().
> 
> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>

Applied, thanks!

> ---
>  Compile tested only.
> 
>  drivers/power/power_supply_core.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/power/power_supply_core.c b/drivers/power/power_supply_core.c
> index 91606bb..f06bad0 100644
> --- a/drivers/power/power_supply_core.c
> +++ b/drivers/power/power_supply_core.c
> @@ -190,10 +190,10 @@ int power_supply_register(struct device *parent, struct power_supply *psy)
>  	goto success;
>  
>  create_triggers_failed:
> -	device_unregister(psy->dev);
> +	device_del(dev);
>  kobject_set_name_failed:
>  device_add_failed:
> -	kfree(dev);
> +	put_device(dev);
>  success:
>  	return rc;
>  }
> -- 
> 1.7.0.4

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/