linux-kernel - Re: [PATCH 2/4] futex,plist: remove debug lock assignment for plist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D119F02.3060900@linux.intel.com>
Date:	Tue, 21 Dec 2010 22:47:30 -0800
From:	Darren Hart <dvhart@...ux.intel.com>
To:	Lai Jiangshan <laijs@...fujitsu.com>
CC:	Peter Zijlstra <peterz@...radead.org>,
	John Kacur <jkacur@...hat.com>,
	James Bottomley <James.Bottomley@...e.de>,
	Ingo Molnar <mingo@...e.hu>, "Rafael J. Wysocki" <rjw@...k.pl>,
	Thomas Gleixner <tglx@...utronix.de>,
	Namhyung Kim <namhyung@...il.com>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH 2/4] futex,plist: remove debug lock assignment for plist_node

On 12/21/2010 09:57 PM, Lai Jiangshan wrote:
> On 12/22/2010 03:14 AM, Darren Hart wrote:
>> On 12/21/2010 01:55 AM, Lai Jiangshan wrote:
>>> original code use&plist_node->plist as the faked head of
>>> the priority list for plist_del(), these debug locks in
>>> the faked head are needed for CONFIG_DEBUG_PI_LIST.
>>>
>>> But now we always pass the real head to plist_del(), the debug locks
>>> in plist_node will not be used, so we remove these assignments.
>>
>> Any reason to keep this separate from  patch 1/4 ?
>>
>
> Make the changes clearer and the patches are easier to read.
> For me the purposes of patch 1/4 and 2/4 are different,
> 1/4 makes the code sensible. 2/4 removes unused code.

Fair enough.

-- 
Darren Hart
Yocto Linux Kernel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/