linux-kernel - Re: [PATCH] kernel: clean up USE_GENERIC_SMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D131E42.1000201@redhat.com>
Date:	Thu, 23 Dec 2010 18:02:42 +0800
From:	Cong Wang <amwang@...hat.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>,
	Koichi Yasutake <yasutake.koichi@...panasonic.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Yinghai Lu <yinghai@...nel.org>, Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jens Axboe <jaxboe@...ionio.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	Venkatesh Pallipadi <venki@...gle.com>,
	linux-am33-list@...hat.com
Subject: Re: [PATCH] kernel: clean up USE_GENERIC_SMP_HELPERS

于 2010年12月22日 21:08, Peter Zijlstra 写道:
> On Mon, 2010-11-29 at 14:06 +0800, Amerigo Wang wrote:
>> For arch which needs USE_GENERIC_SMP_HELPERS, it has to
>> select USE_GENERIC_SMP_HELPERS, rather than leaving a choice
>> to user, since they don't provide their own implementions.
>>
>
>>   config MN10300_CURRENT_IN_E2
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index e330da2..736beea 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -65,6 +65,7 @@ config X86
>>   	select HAVE_SPARSE_IRQ
>>   	select GENERIC_IRQ_PROBE
>>   	select GENERIC_PENDING_IRQ if SMP
>> +	select USE_GENERIC_SMP_HELPERS if SMP
>>
>>   config INSTRUCTION_DECODER
>>   	def_bool (KPROBES || PERF_EVENTS)
>> @@ -203,10 +204,6 @@ config HAVE_INTEL_TXT
>>   	def_bool y
>>   	depends on EXPERIMENTAL&&  DMAR&&  ACPI
>>
>> -config USE_GENERIC_SMP_HELPERS
>> -	def_bool y
>> -	depends on SMP
>> -
>>   config X86_32_SMP
>>   	def_bool y
>>   	depends on X86_32&&  SMP
>
> That changelog and the patch don't match, the patch is a total NOP,
> users never see that config option.

Ok, but isn't 'select' is supposed to be better to express this here? :)
This patch also moves on_each_cpu() to kernel/smp.c, btw.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/