[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20101223.093311.226768777.davem@davemloft.net>
Date: Thu, 23 Dec 2010 09:33:11 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: renton@...ton.name, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org
Subject: Re: 2.6.36.2 - loop on read /proc/net/tcp
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 23 Dec 2010 06:07:26 +0100
> [PATCH] tcp: fix listening_get_next()
>
> Alexey Vlasov found /proc/net/tcp could sometime loop and display
> millions of sockets in LISTEN state.
>
> In 2.6.29, when we converted TCP hash tables to RCU, we left two
> sk_next() calls in listening_get_next().
>
> We must instead use sk_nulls_next() to properly detect an end of chain.
>
> Reported-by: Alexey Vlasov <renton@...ton.name>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists