linux-kernel - Re: [PATCH 00/12] make rpc_pipefs be mountable multiple times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101223180214.GA25865@fieldses.org>
Date:	Thu, 23 Dec 2010 13:02:14 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	"Kirill A. Shutemov" <kas@...nvz.org>
Cc:	Trond Myklebust <Trond.Myklebust@...app.com>,
	Neil Brown <neilb@...e.de>,
	Pavel Emelyanov <xemul@...allels.com>,
	linux-nfs@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/12] make rpc_pipefs be mountable multiple times

On Thu, Dec 23, 2010 at 08:50:33AM +0200, Kirill A. Shutemov wrote:
> On Tue, Dec 21, 2010 at 06:45:21PM -0500, J. Bruce Fields wrote:
> > On Wed, Dec 22, 2010 at 01:32:15AM +0200, Kirill A. Shutemov wrote:
> > > On Mon, Dec 20, 2010 at 09:46:44AM -0500, J. Bruce Fields wrote:
> > > > By the way, was there ever a resolution to Trond's question?:
> > > > 
> > > > 	http://marc.info/?l=linux-nfs&m=128655758712817&w=2
> > > > 
> > > > 	"The keyring upcalls are currently initiated through the same
> > > > 	mechanism as module_request and therefore get started with the
> > > > 	init_nsproxy namespace. We'd really like them to run inside the
> > > > 	same container as the process.  As part of the same problem,
> > > > 	there is the issue of what to do with the dns resolver and
> > > > 	Bryan's new keyring based idmapper code."
> > > 
> > > I'm not sure that I understand the problem correctly.
> > > 
> > > Currently, idmap uses dentry taken from client's cl_rpcclient->cl_path
> > > (see nfs_idmap_new()). cl_rpcclient (and cl_path) is initialized with
> > > rpcmount resolved against mount namespace of mount process (see
> > > nfs_create_rpc_client()).
> > > I assume it's correct.
> > 
> > There's actually two separate sets of idmapper code; look at
> > fs/nfs/idmapper.c, the first part of the file (between #ifdef
> > CONFIG_NFS_USE_NEW_IDMAPPER and #else) is idmapping code that uses
> > request_key().  The code you're looking at (including nfs_idmap_new())
> > is later in the file, and deprecated.
> 
> IIUC, we need to save nsproxy of mount process in struct nfs_client and
> pass it down to request_key(). I think it's outside of this patchset.

OK.  Yes, I wasn't expecting this patchset to deal with it, just
wondered if there was a plan.

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/