linux-kernel - Re: [PATCH v2 2/6] MFD MAX8998/LP3974: Support LP3974 RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTik7Bqzi3FhbQhqqTiJ2CVKfGX-rMPPyrURARsnX@mail.gmail.com>
Date:	Thu, 23 Dec 2010 10:45:55 +0900
From:	MyungJoo Ham <myungjoo.ham@...sung.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Joonyoung Shim <jy0922.shim@...sung.com>,
	Lukasz Majewski <l.majewski@...sung.com>
Subject: Re: [PATCH v2 2/6] MFD MAX8998/LP3974: Support LP3974 RTC

On Wed, Dec 22, 2010 at 10:25 PM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Wed, Dec 22, 2010 at 03:23:07PM +0900, MyungJoo Ham wrote:
>
>> before reading it. If the device name is "lp3974-regerr", the rtc driver
>> assumes that such delays are required. If the device name is "lp3974",
>> the rtc driver does not. Although we have not seen LP3974s without
>> requiring such delays, we assume that such LP3974s will be released
>> soon (or they have done so already) and they are supported by "lp3974".
>
> Might a bit of platform data not be a more robust way of passing this
> in?  If we use the device name then it'd be difficult to handle other
> issues in future.
>
> It's a shame the affected devices can't be identified at runtime :(
>

There should be a register showing "CHIP ID", which can be used to
identify revisions and makers (MAX8998 vs LP3974). However, it is not
written in their datasheet (at least in LP3974 Datasheet Revision 9),
and I have absolutely no information about their "later revisions" of
LP3974.

-- 
MyungJoo Ham (함명주), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/