linux-kernel - Re: [PATCH] dmaengine: provide dummy functions for DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 23 Dec 2010 01:13:59 +0100 (CET)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Dan Williams <dan.j.williams@...el.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: provide dummy functions for DMA_ENGINE=n

On Wed, 22 Dec 2010, Dan Williams wrote:

> On Wed, Dec 22, 2010 at 5:46 AM, Guennadi Liakhovetski
> <g.liakhovetski@....de> wrote:
> > This lets drivers, optionally using the dmaengine, build with DMA_ENGINE
> > unselected.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@....de>
> > ---
> >  include/linux/dmaengine.h |   13 ++++++++++---
> >  1 files changed, 10 insertions(+), 3 deletions(-)
> 
> Is this fixing build errors, or is this just relieving drivers from
> needing to surround calls to dma_{request|release}_channel() with
> ifdef CONFIG_DMA_ENGINE?  The former makes this more urgent, the
> latter can wait for the next merge window.

sh_mmcif.c doesn't compile, if configured for DMA, but DMA_ENGINE is 
unselected. So, yes, this wants to be fixed. But there's more than one way 
to fix it. I've chosen this one, as it seems more generic to me.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/