linux-kernel - Re: [6/7, v9] NUMA Hotplug Emulator: Fake CPU socket with logical CPU on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101223051047.GA13060@shaohui>
Date:	Thu, 23 Dec 2010 13:10:47 +0800
From:	Shaohui Zheng <shaohui.zheng@...ux.intel.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	shaohui.zheng@...el.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, haicheng.li@...ux.intel.com,
	lethal@...ux-sh.org, ak@...ux.intel.com, rientjes@...gle.com,
	dave@...ux.vnet.ibm.com, gregkh@...e.de,
	Sam Ravnborg <sam@...nborg.org>,
	Haicheng Li <haicheng.li@...el.com>
Subject: Re: [6/7, v9] NUMA Hotplug Emulator: Fake CPU socket with logical
 CPU on x86

On Wed, Dec 22, 2010 at 04:27:32PM -0800, Andrew Morton wrote:
> >  static struct task_struct *idle_thread_array[NR_CPUS] __cpuinitdata ;
> > @@ -198,6 +200,8 @@
> >  {
> >  	int cpuid, phys_id;
> >  	unsigned long timeout;
> > +	u8 cpu_probe_on = 0;
> 
> Unneeded initialisation.
> 
> Does this cause an unused var warning when
> CONFIG_ARCH_CPU_PROBE_RELEASE=n?
> 

I am trying to avoid too much ifdef here, it seems it take an unused var
warining when CONFIG_ARCH_CPU_PROBE_RELEASE=n. good catching.

I will figure out a better method.

> > +	struct cpuinfo_x86 *c;
> >  
> >  	/*
> >  	 * If waken up by an INIT in an 82489DX configuration
> >
> > ...
> >
> > +#ifdef CONFIG_ARCH_CPU_PROBE_RELEASE
> > +/*
> > + * Put the logical cpu into a new sokect, and encapsule it into core 0.
> 
> That comment needs help.
> 

Agree, the comment is too simple, should add better documents for function
fake_cpu_socket_info.

-- 
Thanks & Regards,
Shaohui

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/