linux-kernel - Re: [RFC -v9 1/4] Add Kconfig option ARCH_HAVE_NMI_SAFE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1293152205.22308.26.camel@yhuang-dev>
Date:	Fri, 24 Dec 2010 08:56:45 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"peterz@...radead.org" <peterz@...radead.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"rth@...ddle.net" <rth@...ddle.net>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"starvik@...s.com" <starvik@...s.com>,
	"dhowells@...hat.com" <dhowells@...hat.com>,
	"ysato@...rs.sourceforge.jp" <ysato@...rs.sourceforge.jp>,
	"Luck, Tony" <tony.luck@...el.com>,
	"takata@...ux-m32r.org" <takata@...ux-m32r.org>,
	"geert@...ux-m68k.org" <geert@...ux-m68k.org>,
	"monstr@...str.eu" <monstr@...str.eu>,
	"ralf@...ux-mips.org" <ralf@...ux-mips.org>,
	"kyle@...artin.ca" <kyle@...artin.ca>,
	"schwidefsky@...ibm.com" <schwidefsky@...ibm.com>,
	"liqin.chen@...plusct.com" <liqin.chen@...plusct.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"chris@...kel.net" <chris@...kel.net>
Subject: Re: [RFC -v9 1/4] Add Kconfig option ARCH_HAVE_NMI_SAFE_CMPXCHG

Hi, David,

Thanks for review.

On Fri, 2010-12-24 at 01:35 +0800, David Miller wrote:
> From: Huang Ying <ying.huang@...el.com>
> Date: Thu, 23 Dec 2010 13:43:20 +0800
> 
> > --- a/arch/sparc/Kconfig
> > +++ b/arch/sparc/Kconfig
> > @@ -22,6 +22,7 @@ config SPARC
> >  	select RTC_CLASS
> >  	select RTC_DRV_M48T59
> >  	select HAVE_IRQ_WORK
> > +	select ARCH_HAVE_NMI_SAFE_CMPXCHG
> >  	select HAVE_DMA_ATTRS
> >  	select HAVE_DMA_API_DEBUG
> >  	select HAVE_ARCH_JUMP_LABEL
> 
> This should only be set for "SPARC64".  SPARC32's cmpxchg uses spinlocks and
> IRQ disabling, which is not NMI safe.

I will fix this.

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/