linux-kernel - Re: [PATCH 3/9] ASoC: codecs: wm8523: Fix register cache incoherency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101224155929.GC16614@opensource.wolfsonmicro.com>
Date:	Fri, 24 Dec 2010 15:59:30 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Liam Girdwood <lrg@...mlogic.co.uk>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Ian Lartey <ian@...nsource.wolfsonmicro.com>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>
Subject: Re: [PATCH 3/9] ASoC: codecs: wm8523: Fix register cache
 incoherency

On Fri, Dec 24, 2010 at 02:47:58PM +0100, Lars-Peter Clausen wrote:

>  	/* Change some default settings - latch VU and enable ZC */
> -	wm8523->reg_cache[WM8523_DAC_GAINR] |= WM8523_DACR_VU;
> -	wm8523->reg_cache[WM8523_DAC_CTRL3] |= WM8523_ZC;
> +	reg_cache[WM8523_DAC_GAINR] |= WM8523_DACR_VU;
> +	reg_cache[WM8523_DAC_CTRL3] |= WM8523_ZC;

All the drivers where you're making this substitution should in
principle be changed to use snd_soc_update_bits() since we now have
support for multiple cache memory formats so may not have this flat in
memory structure, though for the sake of getting the fixes in it's
probably best to ignore that and fix it up later.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/