linux-kernel - Re: [PATCHv7 16/16] pps: add parallel port PPS signal generator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101224043726.15042d0b@tornado.gnet>
Date:	Fri, 24 Dec 2010 04:37:26 +0300
From:	Alexander Gordeev <lasaine@....cs.msu.su>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	"Nikita V\. Youshchenko" <yoush@...msu.su>,
	linuxpps@...enneenne.com, Rodolfo Giometti <giometti@...eenne.com>,
	Randy Dunlap <rdunlap@...otime.net>, linux-doc@...r.kernel.org,
	john stultz <johnstul@...ibm.com>
Subject: Re: [PATCHv7 16/16] pps: add parallel port PPS signal generator

В Thu, 23 Dec 2010 16:35:49 -0800
Andrew Morton <akpm@...ux-foundation.org> пишет:

> On Mon, 20 Dec 2010 14:54:56 +0300
> Alexander Gordeev <lasaine@....cs.msu.su> wrote:
> 
> > +	expire_time = ktime_to_timespec(timer->_expires);
> 
> It's bad to play around with internal fields, especially when an
> accessor API was provided to access those fields.
> 
> And lo, hrtimers got changed in linux-next:
> 
> drivers/pps/generators/pps_gen_parport.c: In function 'hrtimer_event':
> drivers/pps/generators/pps_gen_parport.c:92: error: 'struct hrtimer'
> has no member named '_expires'
> 
> The documentation in hrtimer.h is of course complete crap and
> Documentation/timers/hrtimers.txt appears to be bitrot, but with a
> little sleuthing and guesswork, it seems that what you want here is

Ah, cool, thanks for the fix!

> ---
> a/drivers/pps/generators/pps_gen_parport.c~pps-add-parallel-port-pps-signal-generator-fix
> +++ a/drivers/pps/generators/pps_gen_parport.c @@ -82,7 +82,7 @@
> static enum hrtimer_restart hrtimer_even 
>  	/* first of all we get the time stamp... */
>  	getnstimeofday(&ts1);
> -	expire_time = ktime_to_timespec(timer->_expires);
> +	expire_time =
> ktime_to_timespec(hrtimer_get_softexpires(timer)); dev =
> container_of(timer, struct pps_generator_pp, timer); lim =
> NSEC_PER_SEC - send_delay - dev->port_write_time; 
> _
> 


-- 
  Alexander

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)