linux-kernel - [PATCH] Ceph: Fix use-after-free in destroy_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1012251858190.10759@swampdragon.chaosbits.net>
Date:	Sat, 25 Dec 2010 19:01:05 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	ceph-devel@...r.kernel.org
cc:	linux-kernel@...r.kernel.org, Sage Weil <sage@...dream.net>
Subject: [PATCH] Ceph: Fix use-after-free in destroy_fs_client()

Hi,

In fs/ceph/super.c::destroy_fs_client() the pointer 'fsc' is freed by 
kfree() and subsequently used in a call to dout() - use after free bug.
Easily fixed by simply moving the kfree() call after the dout() call.

Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
 super.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ceph/super.c b/fs/ceph/super.c
index 08b460a..7373594 100644
--- a/fs/ceph/super.c
+++ b/fs/ceph/super.c
@@ -498,8 +498,8 @@ void destroy_fs_client(struct ceph_fs_client *fsc)
 
 	ceph_destroy_client(fsc->client);
 
-	kfree(fsc);
 	dout("destroy_fs_client %p done\n", fsc);
+	kfree(fsc);
 }
 
 /*


-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/