linux-kernel - RE: [PATCH] coretemp: fix junction temperature for Intel CE4100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <493994B35A117E4F832F97C4719C4C04D781EF3F@orsmsx505.amr.corp.intel.com>
Date:	Sat, 25 Dec 2010 14:28:33 -0800
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	Florian Fainelli <florian@...nwrt.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dirk Brandewie <dirk.brandewie@...il.com>,
	"sodaville@...utronix.de" <sodaville@...utronix.de>
Subject: RE: [PATCH] coretemp: fix junction temperature for Intel CE4100

> -----Original Message-----
> From: Florian Fainelli [mailto:f.fainelli@...il.com] On Behalf Of
> Florian Fainelli
> Sent: Tuesday, December 14, 2010 1:17 PM
> To: linux-kernel@...r.kernel.org; Dirk Brandewie;
> sodaville@...utronix.de; Yu, Fenghua
> Subject: [PATCH] coretemp: fix junction temperature for Intel CE4100
> 
> From: Florian Fainelli <ffainelli@...ebox.fr>
> 
> The Intel CE4100 System-on-a-Chip has a slightly higher junction
> temperature
> (110 degrees Celsius) than other Atom-based hardware.
> 
> Cc: Dirk Brandewie <dirk.brandewie@...il.com>
> Cc: sodaville@...utronix.de
> Cc: Fenghua Yu <fenghua.yu@...el.com>
> Signed-off-by: Florian Fainelli <ffainelli@...ebox.fr>
> ---
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 42de98d..e47b405 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -178,12 +178,23 @@ static int __devinit adjust_tjmax(struct
> cpuinfo_x86 *c, u32 id, struct device *
> 
>  		host_bridge = pci_get_bus_and_slot(0, PCI_DEVFN(0, 0));
> 
> -		if (host_bridge && host_bridge->vendor ==
> PCI_VENDOR_ID_INTEL
> -		    && (host_bridge->device == 0xa000	/* NM10 based
> nettop */
> -		    || host_bridge->device == 0xa010))	/* NM10 based
> netbook */
> -			tjmax = 100000;
> -		else
> -			tjmax = 90000;
> +		if (host_bridge && host_bridge->vendor ==
> PCI_VENDOR_ID_INTEL) {
> +			switch (host_bridge->device) {
> +			/* NM10 based nettop */
> +			case 0xa000:
> +			/* NM10 based netbook */
> +			case 0xa010:
> +				tjmax = 100000;
> +				break;
> +			/* IntelCE Sodaville (CE4100) */
> +			case 0x0708:
> +				tjmax = 110000;
> +				break;
> +			default:
> +				tjmax = 90000;
> +				break;
> +			}
> +		}
> 
>  		pci_dev_put(host_bridge);
>  	}
When host_bridge && host_bridge->vendor == PCI_VENDOR_ID_INTEL is not true, tjmax is not assigned to 90000. This is different from original code.

Could you add public spec URL or public spec name for 110 degrees C in your comments? People may get lost to find this info.

Thanks.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/