linux-kernel - Re: [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101226110101.GA1850@del.dom.local>
Date:	Sun, 26 Dec 2010 12:01:01 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	soete.joel@...rlet.be, eric.dumazet@...il.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-2.6] sundance: Fix oopses with corrupted
 skb_shared_info

On Sat, Dec 25, 2010 at 07:42:10PM -0800, David Miller wrote:
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Sat, 25 Dec 2010 16:12:17 +0100
> 
> > [PATCH net-2.6] sundance: Fix oopses with corrupted skb_shared_info
> > 
> > Joel Soete reported oopses at the beginning of pppoe connections since
> > v2.6.35. After debugging the bug was found in sundance skb allocation
> > and dma mapping code, where skb_reserve() bytes aren't taken into
> > account. This is an old bug, only uncovered by some change in 2.6.35.
> > 
> > Initial debugging patch by: Eric Dumazet <eric.dumazet@...il.com>
> > 
> > Reported-by: Joel Soete <soete.joel@...rlet.be>
> > Tested-by: Joel Soete <soete.joel@...rlet.be>
> > Signed-off-by: Jarek Poplawski <jarkao2@...il.com>
> > Cc: Eric Dumazet <eric.dumazet@...il.com>
> 
> Applied, great work Jarek.
> 
> I was auditing ppp_generic.c hoping I'd find something, but
> if I had that backtrace I wouldn't have bothered :-)

Yes, with the backtrace it was a piece of cake :-) If I knew you're
interested... Anyway, I append a little bit for the record.

Thanks,
Jarek P.


View attachment "joel.syslog-2.6.37-rc7-t2.1000" of type "text/plain" (95434 bytes)