lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Sun, 26 Dec 2010 23:11:19 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	acme@...hat.com, masami.hiramatsu.pt@...achi.com,
	fbuihuu@...il.com, tglx@...utronix.de, vagabon.xyz@...il.com,
	mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org,
	2nddept-manager@....hitachi.co.jp
Subject: Re: [tip:perf/core] perf probe: Fix wrong warning in __show_one_line()
 if read(1) errors happen

(2010/12/25 17:58), tip-bot for Franck Bui-Huu wrote:
> Commit-ID:  32b2b6ec57a3adb3ab7215fbf36ec61c15de06ee
> Gitweb:     http://git.kernel.org/tip/32b2b6ec57a3adb3ab7215fbf36ec61c15de06ee
> Author:     Franck Bui-Huu <vagabon.xyz@...il.com>
> AuthorDate: Wed, 22 Dec 2010 17:37:13 +0100
> Committer:  Arnaldo Carvalho de Melo <acme@...hat.com>
> CommitDate: Wed, 22 Dec 2010 20:32:08 -0200
> 
> perf probe: Fix wrong warning in __show_one_line() if read(1) errors happen
> 
> This was introduced by commit fde52dbd7f71934aba4e150f3d1d51e826a08850.
> 

It's a good fix for me.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>

> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> LKML-Reference: <m3y67hsr0m.fsf@...il.com>
> Signed-off-by: Franck Bui-Huu <fbuihuu@...il.com>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/util/probe-event.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
> index 099336e..4bde988 100644
> --- a/tools/perf/util/probe-event.c
> +++ b/tools/perf/util/probe-event.c
> @@ -309,7 +309,7 @@ static int __show_one_line(FILE *fp, int l, bool skip, bool show_num)
>  	return 1;
>  error:
>  	if (ferror(fp)) {
> -		pr_warning("Source file is shorter than expected.\n");
> +		pr_warning("File read error: %s\n", strerror(errno));
>  		return -1;
>  	}
>  	return 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Masami HIRAMATSU
2nd Dept. Linux Technology Center
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists