linux-kernel - Re: [PATCH 1/1] mct_u232: IOCTL implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101226184124.GA29774@suse.de>
Date:	Sun, 26 Dec 2010 10:41:24 -0800
From:	Greg KH <gregkh@...e.de>
To:	Tsozik <tsozik@...oo.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mct_u232: IOCTL implementation

On Sat, Dec 25, 2010 at 09:39:39PM -0800, Tsozik wrote:
> From: Vadim Tsozik <tsozik@...oo.com>
> 
> Added mct_u232_ioctl function and implemented TIOCMIWAIT and TIOCGICOUNT commands. MCT u232 p9 is one of a few usb to serail adapters which converts USB +/-5v voltage levels to COM +/-15 voltages. So it can also power COM interfaced devices. This makes it very usable for legacy COM interfaced data-acquisition hardware. I tested new implementation with AWARE Electronics RM-60 radiation meter, which sends pulse via RNG COM line whenever new particle is registered.
> 
> Patch below is based on linux-2.6.35.10-72.fc14.x86_64.

Care to make sure this applies on a kernel that we can actually apply
patches to (i.e 2.6.37-rc6?)  The .35 kernel was a long time ago.

> 
> Signed-off-by: Vadim Tsozik <tsozik@...oo.com>
> 
> ---
> --- original/mct_u232.c 2010-12-25 21:31:13.744174626 -0500
> +++ mct_u232.c  2010-12-25 21:44:57.714640343 -0500

Care to read over Documentation/SubmittingPatches which shows you the
proper patch level to make a patch against?

> @@ -24,6 +24,12 @@
>   *   Basic tests have been performed with minicom/zmodem transfers and
>   *   modem dialing under Linux 2.4.0-test10 (for me it works fine).
>   *
> + * 24-Apr-2010 Vadim Tsozik <tsozik@...oo.com>
> + *   - Added implementation of 'TIOCMIWAIT' and 'TIOCGICOUNT' ioctls.
> + *     This routines are necessary if you use mct u232 p9 as data
> + *     acquisition interface. These routines were tested with RM-60 AWARE
> + *     Electronics Radiation Monitor.
> + *

No need to ever add an entry here, your changelog information is now
stored in git,  not in the files themselves.

>   * 04-Nov-2003 Bill Marr <marr at flex dot com>
>   *   - Mimic Windows driver by sending 2 USB 'device request' messages
>   *     following normal 'baud rate change' message.  This allows data to be
> @@ -78,6 +84,8 @@
>  #include <asm/unaligned.h>
>  #include <linux/usb.h>
>  #include <linux/usb/serial.h>
> +#include <linux/serial.h>
> +#include <linux/ioctl.h>
>  #include "mct_u232.h"
> 
>  /*
> @@ -104,6 +112,8 @@ static void mct_u232_break_ctl(struct tt
>  static int  mct_u232_tiocmget(struct tty_struct *tty, struct file *file);
>  static int  mct_u232_tiocmset(struct tty_struct *tty, struct file *file,
>                         unsigned int set, unsigned int clear);
> +static int  mct_u232_ioctl(struct tty_struct *tty, struct file *file,
> +                        unsigned int cmd, unsigned long arg);
>  static void mct_u232_throttle(struct tty_struct *tty);
>  static void mct_u232_unthrottle(struct tty_struct *tty);
> 
> @@ -150,6 +160,7 @@ static struct usb_serial_driver mct_u232
>         .tiocmset =          mct_u232_tiocmset,
>         .attach =            mct_u232_startup,
>         .release =           mct_u232_release,
> +       .ioctl =             mct_u232_ioctl,

Your email client converted the tabs to spaces, making this patch
unable to apply.  Please fix your email client and also run your patch
through the scripts/checkpatch.pl script before sending it to fix up the
formatting errors that are in it.

Care to try again after doing this, and addressing Pete's concerns?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/