linux-kernel - Re: [PATCH] ACPI: use ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D18F332.5090904@zytor.com>
Date:	Mon, 27 Dec 2010 12:12:34 -0800
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Tony Luck <tony.luck@...el.com>
CC:	Len Brown <lenb@...nel.org>, Jack Steiner <steiner@....com>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	gbeshers@....com
Subject: Re: [PATCH] ACPI: use ioremap_cache()

On 12/27/2010 11:42 AM, Tony Luck wrote:
> On Fri, Dec 17, 2010 at 12:08 AM, Len Brown <lenb@...nel.org> wrote:
>> No change on ia64.
> 
> Apart from breaking the build :-(
> 
>> +++ b/arch/ia64/include/asm/io.h
>    ...
>> +static inline void __iomem * ioremap_cache (unsigned long phys_addr, unsigned long size)
>> +{
>> +       return ioremap(unsigned long phys_addr, unsigned long size);
>> +}
> 
> Cut & paste issue? ... the compiler would be a lot happier
> without the "unsigned long"s in the call to ioremap().
> 

LOL...

In the long(er) run it might be worth considering having the same policy
on IA64 as on x86 -- ioremap() meaning ioremap_nocache().

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/