linux-kernel - Re: [PATCH] tg3: fix return value check in tg3_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101227201927.GA6365@bicker>
Date:	Mon, 27 Dec 2010 23:19:27 +0300
From:	Dan Carpenter <error27@...il.com>
To:	David Sterba <dsterba@...e.cz>
Cc:	mcarlson@...adcom.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, Michael Chan <mchan@...adcom.com>
Subject: Re: [PATCH] tg3: fix return value check in tg3_read_vpd()

On Mon, Dec 27, 2010 at 06:31:34PM +0100, David Sterba wrote:
> CC: Matt Carlson <mcarlson@...adcom.com>
> CC: Michael Chan <mchan@...adcom.com>
> Signed-off-by: David Sterba <dsterba@...e.cz>
> ---

Your fix is obviously correct, but could you describe the symptoms
in your changelog instead of leaving it blank?  In the original code,
negative error values are ignored so we never goto out_not_found.  Can
pci_read_vpd() return any errors we care about besides -ENODEV?  What I
mean is, did you find this through analysing the code or did it cause a
bug at runtime?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/