linux-kernel - Re: [PATCHv1 09/12] unicore32 core architecture: timer and time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinjzzMz4WFRYmjZiM=P6c1wtSxpY2bzOuUe0Vrd@mail.gmail.com>
Date:	Mon, 27 Dec 2010 13:27:20 -0800
From:	john stultz <johnstul@...ibm.com>
To:	Guan Xuetao <guanxuetao@...c.pku.edu.cn>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv1 09/12] unicore32 core architecture: timer and time

2010/12/25 Guan Xuetao <guanxuetao@...c.pku.edu.cn>:
> From: Guan Xuetao <guanxuetao@...c.pku.edu.cn>
>
> Patch 9 implements timer and time. RTC and PWM device drivers are also here.
>
> Signed-off-by: Guan Xuetao <guanxuetao@...c.pku.edu.cn>

Just a small request:

> +static struct clocksource cksrc_puv3_oscr = {
> +       .name           = "oscr",
> +       .rating         = 200,
> +       .read           = puv3_read_oscr,
> +       .mask           = CLOCKSOURCE_MASK(32),
> +       .shift          = 18,

Drop the shift assignment here.

> +       cksrc_puv3_oscr.mult =
> +               clocksource_hz2mult(CLOCK_TICK_RATE, cksrc_puv3_oscr.shift);
> +
Drop the mult assignment here.


> +       clocksource_register(&cksrc_puv3_oscr);

Use "clocksource_register_hz(&cksrc_puv3_oscr, CLOCK_TICK_RATE );" and
the kernel will fill in mult/shift appropriately.

If you have any troubles after doing so, let me know.

thanks
-john
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/