linux-kernel - Re: [PATCH][Trivial] sound, ca0106: Fix assignment to 'channel'.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1012271509560.16569@pobox.suse.cz>
Date:	Mon, 27 Dec 2010 15:10:18 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org,
	James Courtier-Dutton <James@...erbug.demon.co.uk>,
	alsa-devel@...a-project.org, Alexey Dobriyan <adobriyan@...il.com>,
	Andy Owen <andy-alsa@...ra-premium.com>,
	Takashi Iwai <tiwai@...e.de>, Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH][Trivial] sound, ca0106: Fix assignment to 'channel'.

On Fri, 24 Dec 2010, Jesper Juhl wrote:

> Hi,
> 
> The assignment to the local variable 'channel' in 
> snd_ca0106_pcm_pointer_capture() is a little crazy.
> Order of assignment is undefined. This fixes it.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
>  ca0106_main.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/sound/pci/ca0106/ca0106_main.c b/sound/pci/ca0106/ca0106_main.c
> index d2d12c0..01b4938 100644
> --- a/sound/pci/ca0106/ca0106_main.c
> +++ b/sound/pci/ca0106/ca0106_main.c
> @@ -1082,7 +1082,7 @@ snd_ca0106_pcm_pointer_capture(struct snd_pcm_substream *substream)
>  	struct snd_pcm_runtime *runtime = substream->runtime;
>  	struct snd_ca0106_pcm *epcm = runtime->private_data;
>  	snd_pcm_uframes_t ptr, ptr1, ptr2 = 0;
> -	int channel = channel=epcm->channel_id;
> +	int channel = epcm->channel_id;
>  
>  	if (!epcm->running)
>  		return 0;
> 

As this doesn't seem to be present in linux-next as of today, I have 
picked it up for trivial queue. Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/