linux-kernel - Re: [PATCH 1/3] HID: picolcd: fix misuse of logical operation in place of bitop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1012271638490.16569@pobox.suse.cz>
Date:	Mon, 27 Dec 2010 16:39:38 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	David Sterba <dsterba@...e.cz>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bruno Prémont <bonbons@...ux-vserver.org>
Subject: Re: [PATCH 1/3] HID: picolcd: fix misuse of logical operation in
 place of bitop

On Mon, 27 Dec 2010, David Sterba wrote:

> CC: Bruno Prémont <bonbons@...ux-vserver.org>
> CC: Jiri Kosina <jkosina@...e.cz>
> Signed-off-by: David Sterba <dsterba@...e.cz>
> ---
>  drivers/hid/hid-picolcd.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hid/hid-picolcd.c b/drivers/hid/hid-picolcd.c
> index bc2e077..0aff3cd 100644
> --- a/drivers/hid/hid-picolcd.c
> +++ b/drivers/hid/hid-picolcd.c
> @@ -1544,7 +1544,7 @@ static ssize_t picolcd_debug_eeprom_read(struct file *f, char __user *u,
>  
>  	/* prepare buffer with info about what we want to read (addr & len) */
>  	raw_data[0] = *off & 0xff;
> -	raw_data[1] = (*off >> 8) && 0xff;
> +	raw_data[1] = (*off >> 8) & 0xff;
>  	raw_data[2] = s < 20 ? s : 20;
>  	if (*off + raw_data[2] > 0xff)
>  		raw_data[2] = 0x100 - *off;
> @@ -1583,7 +1583,7 @@ static ssize_t picolcd_debug_eeprom_write(struct file *f, const char __user *u,
>  
>  	memset(raw_data, 0, sizeof(raw_data));
>  	raw_data[0] = *off & 0xff;
> -	raw_data[1] = (*off >> 8) && 0xff;
> +	raw_data[1] = (*off >> 8) & 0xff;
>  	raw_data[2] = s < 20 ? s : 20;
>  	if (*off + raw_data[2] > 0xff)
>  		raw_data[2] = 0x100 - *off;

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/