linux-kernel - Re: [PATCH] apic: use GFP_ATOMIC in lapic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1012272300070.24243@chino.kir.corp.google.com>
Date:	Mon, 27 Dec 2010 23:00:42 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Zhang Rui <rui.zhang@...el.com>
cc:	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] apic: use GFP_ATOMIC in lapic_resume

On Tue, 28 Dec 2010, Zhang Rui wrote:

> Index: linux-2.6/arch/x86/kernel/apic/apic.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/apic/apic.c
> +++ linux-2.6/arch/x86/kernel/apic/apic.c
> @@ -1459,7 +1459,7 @@ void __init enable_IR_x2apic(void)
>  	if (dmar_table_init_ret && !x2apic_supported())
>  		return;
>  
> -	ioapic_entries = alloc_ioapic_entries();
> +	ioapic_entries = alloc_ioapic_entries(GFP_KERNEL);
>  	if (!ioapic_entries) {
>  		pr_err("Allocate ioapic_entries failed\n");
>  		goto out;
> @@ -2084,7 +2084,7 @@ static int lapic_resume(struct sys_devic
>  
>  	local_irq_save(flags);
>  	if (intr_remapping_enabled) {
> -		ioapic_entries = alloc_ioapic_entries();
> +		ioapic_entries = alloc_ioapic_entries(GFP_ATOMIC);
>  		if (!ioapic_entries) {
>  			WARN(1, "Alloc ioapic_entries in lapic resume failed.");
>  			ret = -ENOMEM;

You can't do the allocation before disabling irqs when 
intr_remapping_enabled is set?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/