linux-kernel - Re: smatch stuff: serial: ifx6x60: oops on load

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101229164134.7eb982a4@lxorguk.ukuu.org.uk>
Date:	Wed, 29 Dec 2010 16:41:34 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dan Carpenter <error27@...il.com>
Cc:	Russ Gorby <richardx.r.gorby@...el.com>,
	Alan Cox <alan@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: smatch stuff: serial: ifx6x60: oops on load

On Mon, 20 Dec 2010 12:15:55 +0300
Dan Carpenter <error27@...il.com> wrote:

> Smatch complains that the ifx6x60 driver in linux-next has a NULL
> dereference.
> 
> drivers/serial/ifx6x60.c +986 ifx_spi_spi_probe(27)
> 	error: potential null derefence 'pl_data'.
> 
>    984          ifx_dev->spi_timer.function = ifx_spi_timeout;
>    985          ifx_dev->spi_timer.data = (unsigned long)ifx_dev;
>    986          ifx_dev->is_6160 = pl_data->is_6160;
>                                    ^^^^^^^
> "pl_data" is always NULL at this point.  Presumably this crashes on load
> every time.

Getting the platform enabling patch in is on the todo list but it depends
on some other bits which are also not yet in the tree.

is_6160 needs to go anyway as it's not what the platform data really
indicates.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/