linux-kernel - Re: [PATCH] gen_init_cpio: Avoid race between call to stat() and call to open()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101229132517.GB15139@sepie.suse.cz>
Date:	Wed, 29 Dec 2010 14:25:17 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Jesper Juhl <jj@...osbits.net>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] gen_init_cpio: Avoid race between call to stat() and
 call to open()

On Fri, Dec 24, 2010 at 05:33:48PM -0500, Jeff Garzik wrote:
> On 12/24/2010 03:28 PM, Jesper Juhl wrote:
> >Hi,
> >
> >In usr/gen_init_cpio.c::cpio_mkfile() a call to stat() is made based on
> >pathname, subsequently the file is open()'ed and then the value of the
> >initial stat() call is used to allocate a buffer. This is not safe since
> >the file may change between the call to stat() and the call to open().
> >Safer to just open() the file and then do fstat() using the filedescriptor
> >returned by open.
> >
> >
> >Signed-off-by: Jesper Juhl<jj@...osbits.net>
> 
> Acked-by: Jeff Garzik <jgarzik@...hat.com>

Looks like an academic issue to me, but the kernel should promote good
programming practices :). Applied to kbuild-2.6.git#kbuild, thanks.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/