linux-kernel - Re: [PATCH][zram] Do not check for init flag before starting I/O

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D1CD751.4000509@vflare.org>
Date:	Fri, 31 Dec 2010 00:32:41 +0530
From:	Nitin Gupta <ngupta@...are.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
CC:	Greg KH <greg@...ah.com>, Pekka Enberg <penberg@...helsinki.fi>,
	Dennis Jansen <dennis.jansen@....de>,
	Linux Driver Project <devel@...uxdriverproject.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][zram] Do not check for init flag before starting I/O

On 12/30/2010 10:47 PM, Linus Torvalds wrote:
> On Thu, Dec 30, 2010 at 1:07 AM, Nitin Gupta<ngupta@...are.org>  wrote:
>> zram module is unusable without this fix.
>
> .. and apparently it oopses without it.
>
> See commit 7e24cce38a99f3 which added the code that you now remove.
> You were cc'd on it, I don't think we got any reply to it.
>

This commit shows oops in zram_inc_stat() which does not exist in 
staging tree version of zram. Its actually a problem with zram version 
as present in project's own repository where we allocate struct 
zram_stats_cpu upon device initialization. OTOH, In mainline/staging 
version of zram, we allocate struct stats upfront, so this oops cannot 
happen in mainline version.

So, this commit is not even applicable for mainline/staging tree.  My 
bad, I didn't get a chance to review that patch.

> So no. I'm not taking this without way more explanations of why the
> original problem isn't a problem any more.
>

I will now end development on local project repository and sync it with 
the mainline version, so all future development happens on 
mainline/staging only, avoiding such confusions in future.

Nitin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/