[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1012310008070.32595@swampdragon.chaosbits.net>
Date: Fri, 31 Dec 2010 00:11:30 +0100 (CET)
From: Jesper Juhl <jj@...osbits.net>
To: linux-media@...r.kernel.org
cc: linux-kernel@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...radead.org>,
Malcolm Priestley <tvboxspy@...il.com>
Subject: [PATVH] media, dvb, IX2505V: Remember to free allocated memory in
failure path (ix2505v_attach()).
Hi,
We may leak the storage allocated to 'state' in
drivers/media/dvb/frontends/ix2505v.c::ix2505v_attach() on error.
This patch makes sure we free the allocated memory in the failure case.
Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
ix2505v.c | 1 +
1 file changed, 1 insertion(+)
Compile tested only.
diff --git a/drivers/media/dvb/frontends/ix2505v.c b/drivers/media/dvb/frontends/ix2505v.c
index 55f2eba..fcb173d 100644
--- a/drivers/media/dvb/frontends/ix2505v.c
+++ b/drivers/media/dvb/frontends/ix2505v.c
@@ -293,6 +293,7 @@ struct dvb_frontend *ix2505v_attach(struct dvb_frontend *fe,
ret = ix2505v_read_status_reg(state);
if (ret & 0x80) {
+ kfree(state);
deb_i2c("%s: No IX2505V found\n", __func__);
goto error;
}
--
Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists