linux-kernel - Re: [v3 1/3] 1/3 Touchscreen: Cypress TTSP G3 MTDEV Core Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101231135800.GA1513@polaris.bitmath.org>
Date:	Fri, 31 Dec 2010 14:58:00 +0100
From:	"Henrik Rydberg" <rydberg@...omail.se>
To:	Trilok Soni <tsoni@...eaurora.org>
Cc:	Kevin McNeely <kev@...ress.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	David Brown <davidb@...eaurora.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Eric Miao <eric.y.miao@...il.com>,
	Mike Frysinger <vapier@...too.org>,
	Alan Cox <alan@...ux.intel.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [v3 1/3] 1/3 Touchscreen: Cypress TTSP G3 MTDEV Core Driver

On Fri, Dec 31, 2010 at 06:25:51PM +0530, Trilok Soni wrote:
> Hi Henrik,
> 
> On 12/31/2010 5:23 PM, Henrik Rydberg wrote:
> > Hi Kevin,
> > 
> > Thanks for the changes, it looks much better now. Some comments on the MT
> > part inline.
> > 
> >> diff --git a/drivers/input/touchscreen/Kconfig b/drivers/input/touchscreen/Kconfig
> >> index 06ea8da..7d886bc 100644
> >> --- a/drivers/input/touchscreen/Kconfig
> >> +++ b/drivers/input/touchscreen/Kconfig
> >> @@ -124,6 +124,11 @@ config TOUCHSCREEN_CY8CTMG110
> >>  	  To compile this driver as a module, choose M here: the
> >>  	  module will be called cy8ctmg110_ts.
> >>  
> >> +config TOUCHSCREEN_CYTTSP_CORE
> >> +	bool "Cypress TTSP touchscreen core"
> >> +	help
> >> +	  Always activated for Cypress TTSP touchscreen
> >> +
> > 
> > Tristate please.
> 
> This code is just exporting APIs and doesn't need to be modular. No module_init/exit etc.,

Any particular reason why "grep cytt /proc/kallsyms | wc" should be
non-zero when no suitable hardware is available?

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/