lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Dec 2010 11:35:12 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: stefani@...bold.net Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org, davem@...emloft.net, netdev@...r.kernel.org Subject: Re: [PATCH] UDPCP Communication Protocol Le vendredi 31 décembre 2010 à 10:29 +0100, stefani@...bold.net a écrit : > /* > + * set a flag for UDPCP message > + */ > + skb->cb[sizeof(struct udp_skb_cb)] = 1; Dont do that. This hides an important thing : you use one extra byte in skb->cb[] without being explicit. As we have one byte hole in struct udp_skb_cbn, you could use it instead. diff --git a/include/net/udp.h b/include/net/udp.h index bb967dd..ceafbbf 100644 --- a/include/net/udp.h +++ b/include/net/udp.h @@ -47,6 +47,7 @@ struct udp_skb_cb { } header; __u16 cscov; __u8 partial_cov; + __u8 udpcp_flag; }; #define UDP_SKB_CB(__skb) ((struct udp_skb_cb *)((__skb)->cb)) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists