linux-kernel - Re: [PATCH 14/18] cx25840: Fix subdev registration in cx25840-core.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 01 Jan 2011 07:58:30 -0500
From:	Andy Walls <awalls@...metrocast.net>
To:	"Igor M. Liplianin" <liplianin@...by>, mchehab@...radead.org,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	ivtv-devel@...vdriver.org
Subject: Re: [PATCH 14/18] cx25840: Fix subdev registration in
 cx25840-core.c

Igor,

The proper fix is here:

https://patchwork.kernel.org/patch/376612/

So, NAK on your particular patch.

Mauro,

I do not see the above patch at linux next.  And I couldn't find it in your kernel.org tree.  What is its status?

This fixes a regression that is known to break cx23885 hardware initialization and can break ivtv hardware initialization.

Regards,
Andy

"Igor M. Liplianin" <liplianin@...by> wrote:

>On my system, cx23885 based card reports default volume value above 70000.
>So, register cx25840 subdev fails. Although, the card don't have a/v inputs
>it needs a/v firmware to be loaded.
>
>Signed-off-by: Igor M. Liplianin <liplianin@...up.ru>
>---
> drivers/media/video/cx25840/cx25840-core.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/video/cx25840/cx25840-core.c
>index dfb198d..dc0cec7 100644
>--- a/drivers/media/video/cx25840/cx25840-core.c
>+++ b/drivers/media/video/cx25840/cx25840-core.c
>@@ -1991,6 +1991,8 @@ static int cx25840_probe(struct i2c_client *client,
> 	if (!is_cx2583x(state)) {
> 		default_volume = 228 - cx25840_read(client, 0x8d4);
> 		default_volume = ((default_volume / 2) + 23) << 9;
>+		if (default_volume > 65535)
>+			default_volume = 65535;
> 
> 		state->volume = v4l2_ctrl_new_std(&state->hdl,
> 			&cx25840_audio_ctrl_ops, V4L2_CID_AUDIO_VOLUME,
>-- 
>1.7.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-media" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html