linux-kernel - Re: [PATCH] nfsd: declare several functions of nfs4callback as static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 1 Jan 2011 16:21:10 -0500
From:	"J. Bruce Fields" <bfields@...ldses.org>
To:	"Kirill A. Shutsemov" <kirill@...temov.name>
Cc:	Neil Brown <neilb@...e.de>, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: declare several functions of nfs4callback as
 static

On Thu, Dec 16, 2010 at 03:25:54PM +0200, Kirill A. Shutsemov wrote:
> From: Kirill A. Shutemov <kirill@...temov.name>
> 
> setup_callback_client(), nfsd4_release_cb() and nfsd4_process_cb_update()
> do not have users outside the translation unit. Let's declare it as
> static.

Thanks, applying for 2.6.38.--b.

> 
> Signed-off-by: Kirill A. Shutemov <kirill@...temov.name>
> ---
>  fs/nfsd/nfs4callback.c |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index a95150d..515a9b1 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -474,7 +474,8 @@ static int max_cb_time(void)
>  /* Reference counting, callback cleanup, etc., all look racy as heck.
>   * And why is cl_cb_set an atomic? */
>  
> -int setup_callback_client(struct nfs4_client *clp, struct nfs4_cb_conn *conn)
> +static int setup_callback_client(struct nfs4_client *clp,
> +		struct nfs4_cb_conn *conn)
>  {
>  	struct rpc_timeout	timeparms = {
>  		.to_initval	= max_cb_time(),
> @@ -750,13 +751,13 @@ void nfsd4_shutdown_callback(struct nfs4_client *clp)
>  	flush_workqueue(callback_wq);
>  }
>  
> -void nfsd4_release_cb(struct nfsd4_callback *cb)
> +static void nfsd4_release_cb(struct nfsd4_callback *cb)
>  {
>  	if (cb->cb_ops->rpc_release)
>  		cb->cb_ops->rpc_release(cb);
>  }
>  
> -void nfsd4_process_cb_update(struct nfsd4_callback *cb)
> +static void nfsd4_process_cb_update(struct nfsd4_callback *cb)
>  {
>  	struct nfs4_cb_conn conn;
>  	struct nfs4_client *clp = cb->cb_clp;
> -- 
> 1.7.3.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/