linux-kernel - Re: [PATCH] misc/cs5535: Fix section mismatch derived from cs5535_mfgpt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110103123431.02a15ba4@queued.net>
Date:	Mon, 3 Jan 2011 12:34:31 -0800
From:	Andres Salomon <dilinger@...ued.net>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Sedat Dilek <sedat.dilek@...glemail.com>,
	sameo@...ux.intel.com, tj@...nel.org, joe@...ches.com,
	linux-kernel@...r.kernel.org, Sedat Dilek <sedat.dilek@...il.com>
Subject: Re: [PATCH] misc/cs5535: Fix section mismatch derived from
 cs5535_mfgpt_drv variable

On Mon, 3 Jan 2011 20:51:31 +0100
Sam Ravnborg <sam@...nborg.org> wrote:

> On Mon, Jan 03, 2011 at 11:43:10AM -0800, Andrew Morton wrote:
> > On Mon,  3 Jan 2011 03:51:28 +0100
> > Sedat Dilek <sedat.dilek@...glemail.com> wrote:
> > 
> > > >From my build.log:
> > > 
> > > WARNING: drivers/misc/cs5535-mfgpt.o(.data+0x0): Section mismatch
> > > in reference from the variable cs5535_mfgpt_drv to the
> > > function .devinit.text:cs5535_mfgpt_probe() The variable
> > > cs5535_mfgpt_drv references the function __devinit
> > > cs5535_mfgpt_probe() If the reference is valid then annotate the
> > > variable with __init* or __refdata (see linux/init.h) or name the
> > > variable: *driver, *_template, *_timer, *_sht, *_ops, *_probe,
> > > *_probe_one, *_console,
> > 
> > Confused.  cs5535_mfgpt_probe() _does_ have a name of the form
> > "*_probe", so why did it warn?
> 
> The varibale need to follow the naming scheme.
> In this case the function was named *_probe - which has no
> significance in the section mismatch checks.
> 
> > > variable with __init* or __refdata (see linux/init.h) or name the
> > > variable:
>     ^^^^^^^^
> ^^^^^^^^^ 
> 
> 	Sam

I see.  So it should really be renamed cs5535_mfgpt_driver, or _drv
added to the whitelist.  Or the whitelist dropped, and all drivers
changed to explicitly mark the structs with __devinitdata.

It's kind of bizarre that we have variable names signifying whether or
not warnings get issued..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/