linux-kernel - Re: [PATCH] writeback: avoid unnecessary determine_dirtyable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTinb+W-hByy18tko8NFtYYzQonABps0gi7+7kQ5R@mail.gmail.com>
Date:	Tue, 4 Jan 2011 07:33:15 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Wu Fengguang <fengguang.wu@...el.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH] writeback: avoid unnecessary determine_dirtyable_memory call

On Tue, Jan 4, 2011 at 7:03 AM, David Rientjes <rientjes@...gle.com> wrote:
> On Tue, 4 Jan 2011, Minchan Kim wrote:
>
>> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
>> index fc93802..c340536 100644
>> --- a/mm/page-writeback.c
>> +++ b/mm/page-writeback.c
>> @@ -390,9 +390,12 @@ void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty)
>>  {
>>       unsigned long background;
>>       unsigned long dirty;
>> -     unsigned long available_memory = determine_dirtyable_memory();
>> +     unsigned long available_memory;
>
> You need unsigned long uninitialized_var(available_memory) to avoid the
> warning.

Yes. It's my fault. Andrew already fixed it.
Thanks, David.


-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/