linux-kernel - Re: [PATCH 2/3] ntp: add ADJ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Jan 2011 09:37:33 +0100
From:	Richard Cochran <richardcochran@...il.com>
To:	John Stultz <john.stultz@...aro.org>
Cc:	"Kuwahara,T." <6vvetjsrt26xsrzlh1z0zn4d2grdah@...il.com>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	Richard Cochran <richard.cochran@...cron.at>
Subject: Re: [PATCH 2/3] ntp: add ADJ_SETOFFSET mode bit

On Mon, Jan 03, 2011 at 12:44:26PM -0800, John Stultz wrote:
> On Wed, 2010-12-29 at 05:47 +0900, Kuwahara,T. wrote:
> > I came up with this simple solution: "Just use ADJ_OFFSET as usual,
> > but don't forget to disable the kernel PLL."
> 
> Again, this seems to be trying to add new functionality into a corner
> case of a existing mode.
> 
> I don't like this because it makes testing and validating that the code
> is correct for its uses difficult. Especially given that a number of
> combinations of modes might be set at once. What happens to freq
> adjustments done at the same time as an ADJ_OFFSET - STA_PLL?

Where are the mode bits and their combinations documented, anyhow?

There are lot of papers on NTP, and I have not read them all, but I
don't recall having seen a precise and succinct decription of the
ntp_adjtime interface anywhere.

Thanks,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/