linux-kernel - Re: [PATCH] intel-iommu: Fix use after release during device attach

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D22F9A4.3050807@web.de>
Date:	Tue, 04 Jan 2011 11:42:44 +0100
From:	Jan Kiszka <jan.kiszka@....de>
To:	Chris Wright <chrisw@...s-sol.org>,
	David Woodhouse <David.Woodhouse@...el.com>
CC:	Sheng Yang <sheng@...ux.intel.com>,
	David Woodhouse <dwmw2@...radead.org>,
	iommu@...ts.linux-foundation.org,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kvm <kvm@...r.kernel.org>, Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH] intel-iommu: Fix use after release during device attach

Am 10.12.2010 19:44, Chris Wright wrote:
> * Jan Kiszka (jan.kiszka@...mens.com) wrote:
>>>>> --- a/drivers/pci/intel-iommu.c
>>>>> +++ b/drivers/pci/intel-iommu.c
>>>>> @@ -3627,9 +3627,9 @@ static int intel_iommu_attach_device(struct
>>>>> iommu_domain *domain,
>>>>>
>>>>>  		pte = dmar_domain->pgd;
>>>>>  		if (dma_pte_present(pte)) {
>>>>> -			free_pgtable_page(dmar_domain->pgd);
>>>>>  			dmar_domain->pgd = (struct dma_pte *)
>>>>>  				phys_to_virt(dma_pte_addr(pte));
> 
> While here, might as well remove the unnecessary cast.
> 
>>>>> +			free_pgtable_page(pte);
>>>>>  		}
>>>>>  		dmar_domain->agaw--;
>>>>>  	}
>>>>
>>>> Reviewed-by: Sheng Yang <sheng@...ux.intel.com>
> 
> Acked-by: Chris Wright <chrisw@...s-sol.org>
> 
>>>> CC iommu mailing list and David.
>>>
>>> Ping...
>>>
>>> I think this fix also qualifies for stable (.35 and .36).
>>>
>>
>> Still not merged?
> 
> David, do you plan to pick this one up?
> 
> thanks,
> -chris

Hmm, still no reaction. Trying David's Intel address now...

Jan


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)