linux-kernel - Re: [RFC][PATCH 0/3] Refactoring sched_entity and sched_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1294164700.6169.197.camel@Palantir>
Date:	Tue, 04 Jan 2011 19:11:40 +0100
From:	Dario Faggioli <raistlin@...ux.it>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Gregory Haskins <ghaskins@...ell.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, Mike Galbraith <efault@....de>,
	Dhaval Giani <dhaval@...is.sssup.it>,
	Fabio Checconi <fabio@...dalf.sssup.it>,
	Darren Hart <darren@...art.com>, oleg <oleg@...hat.com>,
	paulmck <paulmck@...ux.vnet.ibm.com>, pjt@...gle.com,
	bharata@...ux.vnet.ibm.co, lucas.de.marchi@...il.com
Subject: Re: [RFC][PATCH 0/3] Refactoring sched_entity and sched_rt_entity.

On Tue, 2011-01-04 at 17:19 +0100, Peter Zijlstra wrote: 
> > OTOH, groups are always considered both fair _and_ RT entities, for
> > example they're always queued in _both_ an RT run_list and a fair
> > rb-tree. So I can't put them in an union, because I need both at the
> > same time!
> 
> Just like its now, keep a sched_entity per class.
> 
> struct task_group {
> 
> #ifdef CONFIG_FAIR_GROUP_SCHED
> 	struct sched_entity **cfs_se;
> 	...
> #endif
> 
> #ifdef CONFIG_RT_GROUP_SCHED
> 	struct sched_entity **rt_se;
> 	...
> #endif
> 
> }
> 
Well, sure this can be done. But what about the common fields? I guess
you're suggesting to use something like `struct sched_entity_common' and
putting them there, aren't you?

If yes, I'm fine with that, although it'll add one more level of
indirection for those fields (e.g., p->se.comm.on_rq). Are we cool with
this?

> I see once clash with my current ttwu patch set though, see:
> 
>   http://lkml.org/lkml/2011/1/4/228
> 
> But that should be easy to resolve.
>
It's based on current tip, and yes, I plan to keep it updated and solve
the clashes as soon as I run into them. :-)

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
----------------------------------------------------------------------
Dario Faggioli, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa  (Italy)

http://retis.sssup.it/people/faggioli -- dario.faggioli@...ber.org

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)