linux-kernel - Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on Alpha

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110104141151.b6035bf3.randy.dunlap@oracle.com>
Date:	Tue, 4 Jan 2011 14:11:51 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Matt Turner <mattst88@...il.com>, Bob Tracy <rct@...rkin.frus.com>,
	linux-kernel@...r.kernel.org, linux-alpha@...r.kernel.org,
	mcree@...on.net.nz, Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [BUG] implicit declaration of kfree/kzalloc in i2c-i801.c on
 Alpha

On Tue, 4 Jan 2011 22:56:18 +0200 Pekka Enberg wrote:

> On Tue, Jan 4, 2011 at 9:37 PM, Matt Turner <mattst88@...il.com> wrote:
> > On Tue, Jan 4, 2011 at 1:18 AM, Bob Tracy <rct@...rkin.frus.com> wrote:
> >> Another 2.6.37-rc8 build failure on alpha:
> >>
> >> (...)
> >>  CC [M]  drivers/i2c/busses/i2c-i801.o
> >> drivers/i2c/busses/i2c-i801.c: In function 'i801_probe':
> >> drivers/i2c/busses/i2c-i801.c:737: error: implicit declaration of function 'kzalloc'
> >> drivers/i2c/busses/i2c-i801.c:737: warning: assignment makes pointer from integer without a cast
> >> drivers/i2c/busses/i2c-i801.c:855: error: implicit declaration of function 'kfree'
> >> make[3]: *** [drivers/i2c/busses/i2c-i801.o] Error 1
> >> make[2]: *** [drivers/i2c/busses] Error 2
> >> make[1]: *** [drivers/i2c] Error 2
> >> make: *** [drivers] Error 2
> >>
> >> --Bob
> >
> > Is this specific to alpha? I wonder why we don't see this on other platforms?
> 
> The x86 version of <asm/pci.h> includes <linux/slab.h> which hides the
> problem on x86 at least. There was a big cleanup of implicit
> <linux/slab.h> inclusions few months ago which has exposed the
> problem.
> 
> It's a bug in the driver, just add the include there.

exactly.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
desserts:  http://www.xenotime.net/linux/recipes/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/