linux-kernel - Re: [patch 2/2] [SCSI] target: unlock on error path in configfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1294184437.29002.24.camel@haakon2.linux-iscsi.org>
Date:	Tue, 04 Jan 2011 15:40:37 -0800
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Dan Carpenter <error27@...il.com>
Cc:	James Bottomley <James.Bottomley@...e.de>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [patch 2/2] [SCSI] target: unlock on error path in configfs

On Mon, 2011-01-03 at 08:59 +0300, Dan Carpenter wrote:
> If the user wrote a wrong value to the file the it would lead to a dead
> lock eventually.
> 

Good catch on this one.  Commited as 827447968 and pushed into
lio-core-2.6.git.

Thanks!

--nab

> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
> index d7b977d..2764510 100644
> --- a/drivers/target/target_core_configfs.c
> +++ b/drivers/target/target_core_configfs.c
> @@ -660,6 +660,7 @@ static ssize_t target_core_dev_store_attr_##_name(			\
>  	}								\
>  	ret = strict_strtoul(page, 0, &val);				\
>  	if (ret < 0) {							\
> +		spin_unlock(&se_dev->se_dev_lock);                      \
>  		printk(KERN_ERR "strict_strtoul() failed with"		\
>  			" ret: %d\n", ret);				\
>  		return -EINVAL;						\

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/