linux-kernel - RE: [v3 2/3] 2/3 i2c: Cypress TTSP G3 MTDEV I2C Device Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <FB9C2CB29A07AB45B575A4E8D2AABC09014002D4@labamba.mis.cypress.com>
Date:	Tue, 4 Jan 2011 16:37:28 -0800
From:	"Kevin McNeely" <Kevin.McNeely@...ress.com>
To:	"Hong Liu" <hong.liu@...el.com>
Cc:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>,
	"David Brown" <davidb@...eaurora.org>,
	"Trilok Soni" <tsoni@...eaurora.org>,
	"Samuel Ortiz" <sameo@...ux.intel.com>,
	"Eric Miao" <eric.y.miao@...il.com>,
	"Mike Frysinger" <vapier@...too.org>,
	"Henrik Rydberg" <rydberg@...omail.se>,
	"Alan Cox" <alan@...ux.intel.com>, <linux-input@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [v3 2/3] 2/3 i2c: Cypress TTSP G3 MTDEV I2C Device Driver

Hello Hong,

The pointers will be fixed in v4.

Thank you,
Kevin

> -----Original Message-----
> From: Hong Liu [mailto:hong.liu@...el.com]
> Sent: Monday, January 03, 2011 5:46 PM
> To: Kevin McNeely
> Cc: Dmitry Torokhov; David Brown; Trilok Soni; Samuel Ortiz; Eric Miao;
> Mike Frysinger; Henrik Rydberg; Alan Cox; linux-input@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [v3 2/3] 2/3 i2c: Cypress TTSP G3 MTDEV I2C Device Driver
> 
> On Thu, 2010-12-30 at 03:17 +0800, Kevin McNeely wrote:
> [...]
> > +
> > +/* registered in driver struct */
> > +static int __devexit cyttsp_i2c_remove(struct i2c_client *client)
> > +{
> > +	struct cyttsp_i2c *ts;
> > +
> > +	ts = i2c_get_clientdata(client);
> > +	cyttsp_core_release(ts->ttsp_client);
> > +	kfree(ts);
> > +	return 0;
> > +}
> > +
> > +#ifdef CONFIG_PM
> > +static int cyttsp_i2c_suspend(struct i2c_client *client,
> pm_message_t message)
> > +{
> > +	return cyttsp_suspend(dev_get_drvdata(&client->dev));
> > +}
> > +
> > +static int cyttsp_i2c_resume(struct i2c_client *client)
> > +{
> > +	return cyttsp_resume(dev_get_drvdata(&client->dev));
> > +}
> > +#endif
> 
> I think what we get here is a pointer to cyttsp_i2c, and we need to
> pass
> cyttsp_i2c->ttsp_client to cyttsp_suspend/resume.
> 
> Thanks,
> Hong
> 
> > +
> > +static const struct i2c_device_id cyttsp_i2c_id[] = {
> > +	{ CY_I2C_NAME, 0 },  { }
> > +};
> > +
> > +static struct i2c_driver cyttsp_i2c_driver = {
> > +	.driver = {
> > +		.name = CY_I2C_NAME,
> > +		.owner = THIS_MODULE,
> > +	},
> > +	.probe = cyttsp_i2c_probe,
> > +	.remove = __devexit_p(cyttsp_i2c_remove),
> > +	.id_table = cyttsp_i2c_id,
> > +#ifdef CONFIG_PM
> > +	.suspend = cyttsp_i2c_suspend,
> > +	.resume = cyttsp_i2c_resume,
> > +#endif
> > +};
> > +
> > +static int __init cyttsp_i2c_init(void)
> > +{
> > +	return i2c_add_driver(&cyttsp_i2c_driver);
> > +}
> > +
> > +static void __exit cyttsp_i2c_exit(void)
> > +{
> > +	return i2c_del_driver(&cyttsp_i2c_driver);
> > +}
> > +
> > +module_init(cyttsp_i2c_init);
> > +module_exit(cyttsp_i2c_exit);
> > +
> > +MODULE_ALIAS("i2c:cyttsp");
> > +MODULE_LICENSE("GPL");
> > +MODULE_DESCRIPTION("Cypress TrueTouch(R) Standard Product (TTSP) I2C
> driver");
> > +MODULE_AUTHOR("Cypress");
> > +MODULE_DEVICE_TABLE(i2c, cyttsp_i2c_id);
> 


---------------------------------------------------------------
This message and any attachments may contain Cypress (or its
subsidiaries) confidential information. If it has been received
in error, please advise the sender and immediately delete this
message.
---------------------------------------------------------------