linux-kernel - Re: [PATCH 1/2 v2] kref: add kref_test_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110105155619.GB2072@kroah.com>
Date:	Wed, 5 Jan 2011 07:56:19 -0800
From:	Greg KH <greg@...ah.com>
To:	Jerome Marchand <jmarchan@...hat.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Vivek Goyal <vgoyal@...hat.com>,
	Jens Axboe <jaxboe@...ionio.com>,
	Satoru Takeuchi <takeuchi_satoru@...fujitsu.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2 v2] kref: add kref_test_and_get

On Wed, Jan 05, 2011 at 04:02:17PM +0100, Jerome Marchand wrote:
> 
> Add kref_test_and_get() function, which atomically add a reference only if
> refcount is not zero. This prevent to add a reference to an object that is
> already being removed.

Again, no, I do not like this and will not accept this, sorry.

Please read the kref documentation for how to properly handle this,
without this function.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/