linux-kernel - Re: [RFC patch 3/5] ftrace trace event add missing semicolumn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 5 Jan 2011 14:56:12 -0500
From:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [RFC patch 3/5] ftrace trace event add missing semicolumn

* Frederic Weisbecker (fweisbec@...il.com) wrote:
[...]
> Looks good!
> 
> I might be missing corner things but it seems this would reduce the code
> footprint (one function less) and turn more rw into ro datas.
> 
> So it seems to be a very valuable reason to change the semicolon requirement
> all over the place.
> 
> If you come up with this feature along the massive semicolon requirement
> change, we will probably happily apply the whole.
> 
> But coming with only the semicolon change is more like an empty shell.

My proposal here is to incrementally improve the tracing code, starting by
cleaning up what is already there. I cannot do this if you keep asking me for
larger changes to both Ftrace and Perf before any of the prerequisite cleanups
can make their way in.

In this thread, I demonstrated that the TRACE_EVENT cleanup I proposed opens a
lot of code/data size reduction cleanups for Ftrace and Perf. But let's get the
cleanup in there first (it does not break the current way Ftrace and Perf are
working), and once all the code-base has moved to the semicolumn-less semantic,
then we can start improving Ftrace and Perf.

As we say in French, "il ne faut pas mettre la charrue devant les boeufs"
(roughly: don't put the cart before the horse)

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/