linux-kernel - Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <280596192AA74D208C2C5F6389DBE8C1@hacdom.okisemi.com>
Date:	Wed, 5 Jan 2011 11:34:20 +0900
From:	"Tomoya MORINAGA" <tomoya-linux@....okisemi.com>
To:	"Grant Likely" <grant.likely@...retlab.ca>
Cc:	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	<spi-devel-general@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>, <qi.wang@...el.com>,
	<yong.y.wang@...el.com>, <joel.clark@...el.com>,
	<kok.howg.ewe@...el.com>,
	"Toshiharu Okada" <toshiharu-linux@....okisemi.com>
Subject: Re: [PATCH 1/3] spi_topcliff_pch: support new device ML7213

Hi Grant,

On Wednesday, December 29, 2010 3:49 PM, Grant Likely wrote:
> As previously discussed on this list, I would like to see support for
> multiple bus instances implemented differently.  Rather than storing
> the spi_master instances in an array in the pci device private data,
> the pci device should register a separate platform_device for each spi
> bus instance, and each of those bus instances should get bound to a
> topcliff_spi_bus driver which doesn't need to have any special
> knowledge about how many spi_master instances actually exist.
> 
> Basically, the way it is implemented in this patch isn't taking
> advantage of the infrastructure and instance management provided by
> the driver model.

I see.
I will modify like your suggestion.
Could you show the reference SPI driver using multi-instance ?

Thanks,
---
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/